RFR: 8254980: ZGC: ZHeapIterator visits armed nmethods with -XX:-ClassUnloading [v2]

Albert Mingkun Yang ayang at openjdk.java.net
Mon Oct 26 18:11:33 UTC 2020


On Mon, 26 Oct 2020 17:45:27 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> src/hotspot/share/gc/z/zMark.cpp line 585:
>> 
>>> 583:   }
>>> 584: 
>>> 585:   virtual ZNMethodEntry nmethod_entry() const override {
>> 
>> According to the stye-guide we shouldn't use `override` yet. It's used in a few more places in this patch.
>
> Will remove.

I wonder if there's a ticket for revising the style guide to include `override`, which does make the overriding more explicit.

-------------

PR: https://git.openjdk.java.net/jdk/pull/801



More information about the hotspot-gc-dev mailing list