RFR: 8254980: ZGC: ZHeapIterator visits armed nmethods with -XX:-ClassUnloading [v2]

Per Liden pliden at openjdk.java.net
Tue Oct 27 07:38:19 UTC 2020


On Mon, 26 Oct 2020 17:50:45 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> src/hotspot/share/gc/z/zNMethod.cpp line 263:
>> 
>>> 261:       // Only verify
>>> 262:       assert(!ZNMethod::is_armed(nm), "Must be disarmed");
>>> 263: 
>> 
>> Extra white space can be removed.
>
> If you insist. I think this style makes the code easier to read.

Yes please, to me it looks unintended, especially since we don't use that style elsewhere. Maybe flipping the `if (VerifyDisarmed)` and `else if(Disarm)` would make it read better?

-------------

PR: https://git.openjdk.java.net/jdk/pull/801



More information about the hotspot-gc-dev mailing list