RFR: 8254980: ZGC: ZHeapIterator visits armed nmethods with -XX:-ClassUnloading [v3]

Tue Oct 27 08:42:19 UTC 2020

On Thu, 22 Oct 2020 16:18:27 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> Looks good in general. Found 2 VerifyDisarmed that should probably be None instead as I don't think they ever touch an nmethod. If you agree, then I am good with the rest.
>
> Yes, I agree. I revisited my prototype to completely get rid of should_disarm_nmethods/nmethod_entry(), and I came to the same conclusion when updating the code.

Found that during the pre-review of this the code was rearranged and called ZNMethod::nmethod_oops_do twice, when run from the marking code. I've restructured to code to fix that, which at the same time removes stylistic 'else if (' newline.

-------------

PR: https://git.openjdk.java.net/jdk/pull/801