RFR: 8255457: Shenandoah: cleanup ShenandoahMarkTask [v2]

[Roman Kennke]

On Tue, 27 Oct 2020 15:28:01 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> The code in ObjArrayChunkedTask is rough around the edges, and can be cleaned up. It would be further extended in JDK-8254315, so it makes sense to make the change before the bulk of JDK-8254315 arrives.
>
> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix whitespace

Looks ok. Some minor whitespace/formatting nits, but I leave it to you if/what to do about it.

src/hotspot/share/gc/shenandoah/shenandoahTaskqueue.hpp line 167:

> 165: 
> 166:   inline uintptr_t encode_oop(oop obj) const {
> 167:     return ((uintptr_t) (void *) obj) << oop_shift;

Looks like an extra space sneaked in here. Or was that intentional?

src/hotspot/share/gc/shenandoah/shenandoahTaskqueue.hpp line 213:

> 211:   inline bool is_not_chunked() const { return decode_not_chunked(_obj); }
> 212: 
> 213:   DEBUG_ONLY(bool is_valid() const;) // Tasks to be pushed/popped must be valid.

That looks weird. I guess I prefer the previous notation, but it's your call.

-------------

Marked as reviewed by rkennke (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/883