RFR: 8252103: Parallel heap inspection for ParallelScavengeHeap [v6]

Lin Zang lzang at openjdk.java.net
Thu Oct 29 11:00:47 UTC 2020


On Thu, 29 Oct 2020 10:40:07 GMT, Stefan Johansson <sjohanss at openjdk.org> wrote:

>> I made the cast in claim_and_get_block() because I think the itrable_blocks() is not possible to return negative values. and it used in claim_and_get_block() to be a signed int only for helping recoginize survior and eden spaces (the block_index). 
>> BTW, I didn't rebase this patch to master for quite a while,  I will try to rebase it. 
>> Thanks!
>
> You should not rebase, but **merge** with master, to avoid having to force push.
> 
> I agree that adding the cast in `claim_and_get_block()` is better, but you still need to update the return value to be `size_t` here. Otherwise you will still fail with the error seen above.

Thanks @kstefanj, I am thinking of the way to not losing review information with rebase. seem merge it better. and I will make the size_t change.

-------------

PR: https://git.openjdk.java.net/jdk/pull/25



More information about the hotspot-gc-dev mailing list