RFR: 8255595: delay_to_keep_mmu passes wrong arguments to Monitor wait

Albert Mingkun Yang ayang at openjdk.java.net
Thu Oct 29 15:40:43 UTC 2020


On Thu, 29 Oct 2020 15:04:06 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> Please review this trivial fix of the second argument in a call to MonitorLocker::wait.  Because the locker is constructed as no-safepoint-checking, the improper second argument is ignored rather than possibly going into an unexpected state.
>
> Lgtm and trivial.

I wonder if it's feasible and/or worthwhile to use `clang-tidy` (or sth similar) to detect this kind of error in existing code and prevent it from happening again in new code.

-------------

PR: https://git.openjdk.java.net/jdk/pull/934



More information about the hotspot-gc-dev mailing list