RFR(XS): 8252303 : G1MMUTrackerQueue::when_sec skip queue iteration on max_gc_time pause time

Thomas Schatzl thomas.schatzl at oracle.com
Wed Sep 2 09:28:00 UTC 2020


Hi,

On 02.09.20 11:25, Ivan Walulya wrote:
> Thanks Stefan!
> 
> //Ivan
> 
>> On 2 Sep 2020, at 11:16, stefan.johansson at oracle.com wrote:
>>
>> Hi Ivan,
>>
>> On 2020-08-25 13:17, Ivan Walulya wrote:
>>> Hi All,
>>> Please review this enhancement in G1MMUTrackerQueue to skip unnecessary buffer iterations.
>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8252303
>>> Webrev: http://cr.openjdk.java.net/~iwalulya/8252303/00/
>>
>> Sorry for the delay. Looks good, just a minor thing. After the removed statement in add_pause, it now starts with a blank line. I think you can remove that one as well. No need for a new webrev.
>>

+1 - please also fix the extra spaces in line 143 of g1MMUTracker.cpp 
(after the "return" and before the "-").

Thanks,
   Thomas



More information about the hotspot-gc-dev mailing list