[Patch] ParallelGC: Improve AlwaysPreTouch with multiple threads

Thomas Schatzl thomas.schatzl at oracle.com
Fri Sep 4 08:41:08 UTC 2020


Hi,

On 04.09.20 10:11, stefan.johansson at oracle.com wrote:
> Hi Amit,
> 
> A short heads up =)
> 
> We are in the middle of transitioning OpenJDK to git and GitHub, see JEP 
> 369 [1]. We will not have time to complete this review before the move 
> takes place. Instead it will have to be restarted using GitHub. An 
> introduction and great source of information on how to get started with 
> the new workflow can be found on the project Skara wiki [2].
> 
> The move is scheduled for tomorrow [3], so starting next week you should 
> be able to create your own PR on GitHub for this change.

+1

Fwiw, a cursory glance at the change also showed lots of whitespace 
related issues (spacing around "*", spaces around casts, missing curly 
braces, missing spaces between "if" and "(") that should be fixed.

Please look at surrounding code or the hotspot style guide 
(https://wiki.openjdk.java.net/display/HotSpot/StyleGuide) for guidance.

Thanks,
   Thomas



More information about the hotspot-gc-dev mailing list