RFR: 8027545: Improve object array chunking test in G1's copy_to_survivor_space [v2]

Kim Barrett kim.barrett at oracle.com
Sat Sep 12 00:30:44 UTC 2020


> On Sep 11, 2020, at 6:47 AM, Stefan Johansson <sjohanss at openjdk.java.net> wrote:
> 
> On Fri, 11 Sep 2020 09:01:18 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:
>> Kim Barrett has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>  Respond to reviews by ayang and sjohanss.
> 
> Nice test and thanks for going with "objarray".
> 
> Looks good and I'll approve this now, but please fix the indent issue in the test before integrating.

Thanks, will do.

> test/hotspot/gtest/gc/shared/test_partialArrayTaskStepper.cpp line 55:
> 
>> 53:                      int length,
>> 54:                      int* to_length_addr,
>> 55:                      uint chunk_size) {
> 
> Indent looks to be one-off here.

Yeah, changed return type from void to int at some point and missed adjusting the indentation.




More information about the hotspot-gc-dev mailing list