RFR: 8253219: Epsilon: clean up unnecessary includes
Thomas Schatzl
thomas.schatzl at oracle.com
Wed Sep 16 11:03:58 UTC 2020
Hi,
On 16.09.20 13:00, Aleksey Shipilev wrote:
> On 9/16/20 12:52 PM, Thomas Schatzl wrote:
>> Hi,
>>
>> On 16.09.20 09:49, Aleksey Shipilev wrote:
>>> Static analysis shows a few #include statements in gc/epsilon that
>>> are not needed.
>>>
>>> Testing: Linux x86_64 {release, fastdebug, slowdebug} x {+PCH, -PCH}
>>>
>>
>> - in epsilonMonitoringSupport.cpp, the include for allocation.inline.hpp
>> is correct, CHeapObj is declared there.
>> The allocation.hpp one is superfluous though.
>
> Seems vice versa: allocation.hpp defines CHeapObj and needs to be
> included, and allocation.inline.hpp needs to be dropped. Updated.
>
I tend to always prefer the .inline.hpp if available as something
might be defined in the .inline.hpp that is used in the .hpp file. I.e.
as a rule include to .inline.hpp if available. It does not seem to be
the case here so just the .hpp should be good.
Looks good.
Thomas
More information about the hotspot-gc-dev
mailing list