RFR: 8253219: Epsilon: clean up unnecessary includes [v2]
Aleksey Shipilev
shade at openjdk.java.net
Wed Sep 16 11:20:20 UTC 2020
On Wed, 16 Sep 2020 11:12:04 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:
>> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Reinstate allocation.hpp include
>
> Marked as reviewed by kbarrett (Reviewer).
> _Mailing list message from [Thomas Schatzl](mailto:thomas.schatzl at oracle.com) on
> [hotspot-gc-dev](mailto:hotspot-gc-dev at openjdk.java.net):_ I tend to always prefer the .inline.hpp if available as
> something might be defined in the .inline.hpp that is used in the .hpp file. I.e.
> as a rule include to .inline.hpp if available. It does not seem to be
> the case here so just the .hpp should be good.
Right. I do as crystal^W static analyzer guides: include only what is necessary.
Integrating now.
-------------
PR: https://git.openjdk.java.net/jdk/pull/198
More information about the hotspot-gc-dev
mailing list