RFR: 8252041: G1: Fix incorrect uses of HeapRegionManager::max_length

[Thomas Schatzl]

On Wed, 16 Sep 2020 09:14:20 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> Thanks for cleaning this up Thomas.
>> 
>> The changes look good but I find these two names a bit confusing since that are so similar, what do you think about:
>> `max_regions()` -> `reserved_regions()`
>> `max_expandable_regions()` -> `max_regions()`
>> 
>> And similar for the functions in the HeapRegionManager, what do you think about this?
>
> Hi,
> 
> On 16.09.20 10:50, Stefan Johansson wrote:
>> *@kstefanj* commented on this pull request.
>> 
>> Thanks for cleaning this up Thomas.
>> 
>> The changes look good but I find these two names a bit confusing since
>> that are so similar, what do you think about:
>> |max_regions()| -> |reserved_regions()|
>> |max_expandable_regions()| -> |max_regions()|
>> 
>> And similar for the functions in the HeapRegionManager, what do you
>> think about this?
>> 
> 
> Fine with me - I considered this but then kept this. Thanks for your
> early feedback!
> 
> Thanks,
>    Thomas

Actually I have second thoughts about the suggestions: this would introduce a "_regions" prefix to just these two
members in HeapRegionManager. What about "max_length" and "reserved_length" in HRM?
The suggested names are fine with me in other code not directly using HRM (pretty much all of it).

-------------

PR: https://git.openjdk.java.net/jdk/pull/178