RFR: 8244505: G1 pause time ratio calculation does not consider Remark/Cleanup pauses [v3]

[Ivan Walulya]

On Wed, 16 Sep 2020 13:43:39 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> Ivan Walulya has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Changes made to address reviews from Thomas.
>
> Marked as reviewed by tschatzl (Reviewer).

> _Mailing list message from [Thomas Schatzl](mailto:thomas.schatzl at oracle.com) on
> [hotspot-gc-dev](mailto:hotspot-gc-dev at openjdk.java.net):_
> Hi,
> 
> On 16.09.20 15:17, Ivan Walulya wrote:
> 
> > > The computation for long and short term pause time ratios does not include Remark/Cleanup pause times. Isolate updates
> > > to _prev_collection_pause_end_ms from update_recent_gc_times(), then have all gc pauses (including Remark/Cleanup)
> > > recorded by update_recent_gc_times(). Patch also includes trivial clean ups to g1Policy.* files. Testing: Tier 1 - 7
> > > Performance testing did not show any significant changes in performance
> > 
> > 
> > Ivan Walulya has updated the pull request incrementally with one additional commit since the last revision:
> > Changes made to address reviews from Thomas.
> > -------------
> 
> The comment at the declaration of G1Policy::should_update_gc_stats() is
> better placed at the implementation as it is imho.
> 
> You could move it there if you want.

I agree, will move it.

> 
> Also thanks for catching the issue with "*1000*0", I forgot to mention
> it earlier.
> 
> Lgtm. Thanks.
> 
> Thomas

Thanks Thomas,

-------------

PR: https://git.openjdk.java.net/jdk/pull/183