RFR: 8253332: ZGC: Make heap views reservation platform independent [v2]

[Aleksey Shipilev]

On Fri, 18 Sep 2020 08:39:59 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Stefan Karlsson has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review 1
>
> src/hotspot/os/posix/gc/z/zVirtualMemory_posix.cpp line 45:
> 
>> 43:   if (res != addr) {
>> 44:     // Failed to reserve memory at the requested address
>> 45:     munmap((void*)res, size);
> 
> No assert for `munmap` result? I don't care either way, but it would probably be nice to capture this.

Also, hold on a sec. Shouldn't this path `return 0` too? Otherwise callers get the non-zero address that is effectively
unusable.

-------------

PR: https://git.openjdk.java.net/jdk/pull/236