RFR: 8253332: ZGC: Make heap views reservation platform independent [v3]

Per Lidén pliden at openjdk.java.net
Fri Sep 18 15:17:03 UTC 2020


On Fri, 18 Sep 2020 09:29:29 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Stefan Karlsson has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review 2
>
> Still look fine.

> I choose to prefix the OS dependent functions with os_. For consistency, initialize_os should have been renamed as
> well, but the plan is to change that in a separate patch that splits that function into two, so I skipped it for now.

May I suggest that we instead just keep to the convention we have (here and in other classes) and use an _os suffix on
these new functions?

-------------

PR: https://git.openjdk.java.net/jdk/pull/236



More information about the hotspot-gc-dev mailing list