RFR: 8253332: ZGC: Make heap views reservation platform independent [v4]

Per Lidén pliden at openjdk.java.net
Mon Sep 21 10:58:00 UTC 2020


On Mon, 21 Sep 2020 10:20:28 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> Marked as reviewed by pliden (Reviewer).
>
>> @stefank That convention actually goes back to when ZGC was first integrated, with *_platform. However some of
>> those *_platform functions has been removed over time as they were no longer needed. When the Windows port came in we
>> said we should move away from *_platform to *_os, *_cpu and *_os_cpu to be more explicit and cater for potential future
>> needs. To me, the suffix-style reads a bit better, the relationship between e.g. initialize() and initialize_os()
>> becomes a bit more obvious, and it maps well to the platform specific file name convention we have in HotSpot
>> (e.g. *_linux_x86.hpp). Having said that, I'm ok with changing the convention to prefix-style.
> 
> About the last point: HotSpot code uses suffix for the platform file names, but the pd part is mostly a prefix.
> 
> Would you mind if I changed the few x_platform functions we have to pd_x functions? That way we don't invent our own
> way to mark platform-dependent code.

@stefank That would work for me.

-------------

PR: https://git.openjdk.java.net/jdk/pull/236



More information about the hotspot-gc-dev mailing list