Integrated: 8253411: [BACKOUT] [REDO] G1 incorrectly limiting young gen size when using the reserve can result in repeated full gcs

Thomas Schatzl tschatzl at openjdk.java.net
Mon Sep 21 11:34:40 UTC 2020


On Mon, 21 Sep 2020 09:40:26 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

> Hi all,
> 
>   can I have some reviews for this change that reverts commit fa30241ddbbe953b61526bc3c44784198acdd801.
> 
> Fix some merge error in this hunk:
> 
> From https://github.com/openjdk/jdk/commit/3570f5a9,  8252041: G1: Fix incorrect uses of HeapRegionManager::max_length
> , the method "max_expandable_regions()" has been changed to "max_regions()" so the first use of it in the hunk
> @@ -108,11 +107,14 @@ void G1Policy::init(G1CollectedHeap* g1h, G1CollectionSet* collection_set) {
> 
> +   if (!use_adaptive_young_list_length()) {
> +    _young_list_fixed_length = _young_gen_sizer->min_desired_young_length();
> +  }
>   _young_gen_sizer->adjust_max_new_size(_g1h->max_regions());  // <------------- here!
> 
> Did not revert cleanly. Everything else is unchanged.
> 
> Testing: local compilation. tier1-tier3 running

This pull request has now been integrated.

Changeset: bba948f0
Author:    Thomas Schatzl <tschatzl at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/bba948f0
Stats:     409 lines in 3 files changed: 204 ins; 76 del; 129 mod

8253411: [BACKOUT] [REDO] G1 incorrectly limiting young gen size when using the reserve can result in repeated full gcs

Reviewed-by: kbarrett, sjohanss

-------------

PR: https://git.openjdk.java.net/jdk/pull/281



More information about the hotspot-gc-dev mailing list