RFR: 8253434: Shenandoah: Cleanup ShenandoahRootScanner
Roman Kennke
rkennke at openjdk.java.net
Mon Sep 21 18:31:01 UTC 2020
On Mon, 21 Sep 2020 18:25:04 GMT, Roman Kennke <rkennke at openjdk.org> wrote:
>> After moving CLDG mark to concurrent phase, ShenandoahRootScanner::strong_roots_do() and
>> ShenandoahRootScanner::roots_do() are practical the same, let's trim one.
>> Test:
>> hotspot_gc_shenandoah
>
> src/hotspot/share/gc/shenandoah/shenandoahRootProcessor.cpp line 192:
>
>> 190:
>> 191: void ShenandoahRootScanner::roots_do(uint worker_id, OopClosure* oops) {
>> 192: CLDToOopClosure clds_cl(oops, ClassLoaderData::_claim_none);
>
> Are you sure that we don't have to claim CLDs? How would the threads avoid doubly-marking CLDs?
Actually it looks like the CLD closure is not used at all, or is it?
-------------
PR: https://git.openjdk.java.net/jdk/pull/286
More information about the hotspot-gc-dev
mailing list