RFR: 8251358: Clean up Access configuration after Shenandoah barrier change [v2]

Erik Österlund eosterlund at openjdk.java.net
Thu Sep 24 07:30:29 UTC 2020


On Wed, 23 Sep 2020 01:13:08 GMT, Aditya Mandaleeka <adityam at openjdk.org> wrote:

>> This change removes a bunch of code that is no longer necessary after the Shenandoah barrier changes, including the
>> `SUPPORT` macros in barrierSetConfig.hpp and code using them. `Access::resolve` and associated code have also been
>> removed, and callers have been modified.  Testing done:
>> tier1
>> hotspot_gc_shenandoah
>
> Aditya Mandaleeka has updated the pull request with a new target base due to a merge or a rebase. The incremental
> webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits
> since the last revision:
>  - Remove redundant _raw functions.
>  - 8251358: Clean up Access configuration after Shenandoah barrier change

Oops seems like I didn't publish the comments somehow.

src/hotspot/share/oops/oop.hpp line 62:

> 60:  public:
> 61:   inline markWord  mark()          const;
> 62:   inline markWord* mark_addr_raw() const;

mark_addr_raw should now be mark_addr.

src/hotspot/share/oops/oop.hpp line 65:

> 63:
> 64:   inline void set_mark(markWord m);
> 65:   static inline void set_mark_raw(HeapWord* mem, markWord m);

set_mark_raw should now be set_mark.

-------------

Changes requested by eosterlund (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/146



More information about the hotspot-gc-dev mailing list