RFR: 8253594: Remove CollectedHeap::supports_tlab_allocation

Stefan Karlsson stefank at openjdk.java.net
Thu Sep 24 12:56:45 UTC 2020


On Thu, 24 Sep 2020 11:59:34 GMT, Stefan Johansson <sjohanss at openjdk.org> wrote:

>> CollectedHeap::supports_tlab_allocation always returns true, and is only used in an assert. I propose that we remove it.
>> 
>> GenCollectedHeap is the only implementation that didn't trivially return true. Instead it deferred the question to the
>> young gen, which after the CMS removal is only DefNew. I updated the GenCollectedHeap tlab functions to assert that the
>> young gen always supports TLABs. This could be taken even further, and the Generation::supports_tlab_allocation()
>> function could be entierly removed, but that requires that we change GenCollectedHeap to be explicit about the types
>> for _young_gen and _old_gen. So, I left  that part for another day.
>
> Marked as reviewed by sjohanss (Reviewer).

Thanks @pliden and @kstefanj for reviewing.

-------------

PR: https://git.openjdk.java.net/jdk/pull/335



More information about the hotspot-gc-dev mailing list