Integrated: 8264027: Refactor "CLEANUP" region printing
Thomas Schatzl
tschatzl at openjdk.java.net
Tue Apr 6 10:07:28 UTC 2021
On Mon, 29 Mar 2021 12:43:12 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:
> Hi all,
>
> can I have reviews for this small cleanup that refactors "CLEANUP" region status printing?
>
> - where managing a `FreeRegionList` is not necessary, inline the call to the method (which is guarded by a check that if logging is not enabled, we do not print anything anyway)
> - for the single remaining case, create a helper method in `G1HRPrinter`
>
> The first item has been done as per the suggestion from @kstefanj [here](https://github.com/openjdk/jdk/pull/3154#pullrequestreview-619061961) ; the alternative would be to keep the free region lists and call `G1HRPrinter::cleanup` on it later, which I actually initially implemented. I could not find a difference performance-wise.
>
> Testing: checked if there is some perf difference on a heap with 50k regions; tier1-3
This pull request has now been integrated.
Changeset: bf26a255
Author: Thomas Schatzl <tschatzl at openjdk.org>
URL: https://git.openjdk.java.net/jdk/commit/bf26a255
Stats: 71 lines in 4 files changed: 44 ins; 21 del; 6 mod
8264027: Refactor "CLEANUP" region printing
Reviewed-by: kbarrett, ayang
-------------
PR: https://git.openjdk.java.net/jdk/pull/3243
More information about the hotspot-gc-dev
mailing list