RFR: 8264682: MemProfiling does not own Heap_lock when using G1

[David Holmes]

On 7/04/2021 12:34 am, Coleen Phillimore wrote:
> On Tue, 6 Apr 2021 02:04:57 GMT, David Holmes <dholmes at openjdk.org> wrote:
> 
>>> Trivial fix for JDK-8264682.
>>>
>>> `Universe::heap()->used()` calls G1Allocator::used_in_alloc_regions() when G1 enabled,  it checks whether Heap_lock was owned on this thread's behalf.
>>
>> Sorry but I have to agree with Kim that this is the wrong fix for this problem.
>>
>> And the test needs adjusting.
>>
>> Thanks,
>> David
> 
> Unless we can imagine a reason why this code is needed, I think the old memprofiler should be removed.

Why was it added? I've no idea who might be using this, or for what. But 
I think removing it is a separate issue.

Cheers,
David

> -------------
> 
> PR: https://git.openjdk.java.net/jdk/pull/3340
>