RFR: 8264424: Support OopStorage bulk allocation [v2]

[Kim Barrett]

On Tue, 6 Apr 2021 09:46:52 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> Kim Barrett has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   improve comments per ayang
>
> src/hotspot/share/gc/shared/oopStorage.cpp line 478:
> 
>> 476:     block = block_for_allocation();
>> 477:     if (block == NULL) return 0; // Block allocation failed.
>> 478:     // Take exclusive use of this block for allocation.
> 
> Maybe "Taking all remaining entries, so remove from list."? The "exclusive use" is ensured by the above `MutexLocker`, not `unlink`.

done

> src/hotspot/share/gc/shared/oopStorage.hpp line 119:
> 
>> 117:   // Allocates multiple entries, returning them in the ptrs buffer.  The
>> 118:   // number of entries that will be allocated is never more than the minimum
>> 119:   // of size and bulk_allocate_limit, but may be less than either.  Possibly
> 
> It took me a few seconds to understand this sentence. Maybe replace it with "postcondition: result <= min(size, bulk_allocate_limit)" below?

done

-------------

PR: https://git.openjdk.java.net/jdk/pull/3264