RFR: 8264423: G1: Rename full gc attribute table states [v2]

[Hamlin Li]

On Wed, 14 Apr 2021 10:55:10 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> Hi all,
>> 
>>   please review this cleanup change suggested in PR#2760 that renames some code in the g1 full gc attribute table.
>> 
>> This is the description from the CR:
>> 
>>>  Since JDK-8253600 g1 full gc has its own (temporary) attribute table storing information that it needs for evacuation.
>>> 
>>> Currently the naming corresponds to the attributes in HeapRegion. This is somewhat confusing, as they do not completely match.
>>> 
>>> While discussing this in the review for JDK-8262068 we thought of changing this to more reflect the purpose:
>>> 
>>> I.e.
>>> closed -> not_marked_through (or "always live" or "always_marked" something similar to indicate that we do not need to mark through them)
>>> pinned -> not_compacted
>>> normal -> compacted (or just keep "normal" as it is some internal state) 
>> 
>> Some additional renaming has been performed.
>> 
>> Testing: tier1-5
>
> Thomas Schatzl has updated the pull request incrementally with one additional commit since the last revision:
> 
>   sjohanss review - remove double negation

src/hotspot/share/gc/g1/g1FullGCHeapRegionAttr.hpp line 71:

> 69:   }
> 70: 
> 71:   bool is_compacted_or_marked_through(uint idx) const {

Should this be rename to is_compacted_or_not_marked_through?
As the condition is indeed == Compacted || == NotMarkedThrough.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3486