Integrated: 8264423: G1: Rename full gc attribute table states

Thomas Schatzl tschatzl at openjdk.java.net
Thu Apr 15 08:15:36 UTC 2021


On Wed, 14 Apr 2021 08:37:06 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

> Hi all,
> 
>   please review this cleanup change suggested in PR#2760 that renames some code in the g1 full gc attribute table.
> 
> This is the description from the CR:
> 
>>  Since JDK-8253600 g1 full gc has its own (temporary) attribute table storing information that it needs for evacuation.
>> 
>> Currently the naming corresponds to the attributes in HeapRegion. This is somewhat confusing, as they do not completely match.
>> 
>> While discussing this in the review for JDK-8262068 we thought of changing this to more reflect the purpose:
>> 
>> I.e.
>> closed -> not_marked_through (or "always live" or "always_marked" something similar to indicate that we do not need to mark through them)
>> pinned -> not_compacted
>> normal -> compacted (or just keep "normal" as it is some internal state) 
> 
> Some additional renaming has been performed.
> 
> Testing: tier1-5

This pull request has now been integrated.

Changeset: 75da1e9a
Author:    Thomas Schatzl <tschatzl at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/75da1e9a
Stats:     71 lines in 8 files changed: 6 ins; 22 del; 43 mod

8264423: G1: Rename full gc attribute table states

Reviewed-by: sjohanss, mli

-------------

PR: https://git.openjdk.java.net/jdk/pull/3486



More information about the hotspot-gc-dev mailing list