RFR: JDK-8264987: G1: Fill BOTs for Survivor-turned-to-Old regions in full gc [v2]
Hamlin Li
mli at openjdk.java.net
Thu Apr 15 12:29:37 UTC 2021
On Thu, 15 Apr 2021 08:07:13 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:
>> Hamlin Li has updated the pull request incrementally with one additional commit since the last revision:
>>
>> refine the code.
>
> src/hotspot/share/gc/g1/g1FullGCPrepareTask.cpp line 71:
>
>> 69: force_pinned = true;
>> 70: if (hr->is_young()) {
>> 71: // Old regions have BOTs info for performance consideration, but young regions
>
> I'd replace this comment with something like this:
>
> // G1 updates the BOT for old region contents incrementally, but young regions lack BOT
> // information for performance reasons.
> // Recreate BOT information of high live ratio young regions here to keep expected
> // performance during scanning their card tables in the collection pauses later.
>
> Or something like this...
Thanks Thomas for refining the comments.
-------------
PR: https://git.openjdk.java.net/jdk/pull/3459
More information about the hotspot-gc-dev
mailing list