RFR: 8199407: Skip Rebuild Remset Phase if there are no rebuild candidates [v2]
Ivan Walulya
iwalulya at openjdk.java.net
Fri Apr 16 12:07:50 UTC 2021
On Fri, 16 Apr 2021 12:00:52 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:
>> Ivan Walulya has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains eight additional commits since the last revision:
>>
>> - Fix issues raised in Thomas review, and add test
>> - Merge remote-tracking branch 'upstream/master' into JDK-8199407
>> - remove trailing white space
>> - Merge branch 'master' into JDK-8199407
>> - variable name refactor
>> - variable name refactor
>> - skip iterations that depend on total_selected_for_rebuild
>> - skip the rebuild remembered set phase if remark did not select any regions for rebuilding
>
> test/hotspot/jtreg/gc/g1/TestSkipRebuildRemsetPhase.java line 85:
>
>> 83:
>> 84: private static Object alloc() {
>> 85: // G1MixedGCLiveThresholdPercent=20
>
> Maybe this comment could be elaborated a bit further - i.e. "Since G1Mixed...ent is 20%, make sure to allocate something that is larger than that so that it will not be collected and the expected message printed."
> Or just remove it.
I think it is better to elaborate than remove.
-------------
PR: https://git.openjdk.java.net/jdk/pull/3434
More information about the hotspot-gc-dev
mailing list