RFR: 8265326: Strange Characters in G1GC GC Log

[Stefan Johansson]

On Tue, 20 Apr 2021 12:19:08 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> There was an character formating issue on mac-os due to usage of "
>> `FormatBuffer<128>`" 
>> Used explicit variable to hold the FormatBuffer
>
> src/hotspot/share/gc/g1/g1ConcurrentMarkThread.cpp line 143:
> 
>> 141:     GCIdMark gc_id_mark;
>> 142:     FormatBuffer<128> _format("Concurrent %s Cycle", _state == FullMark ? "Mark" : "Undo");
>> 143:     GCTraceConcTime(Info, gc) tt(_format);
> 
> Suggestion:
> 
>     FormatBuffer<128> title("Concurrent %s Cycle", _state == FullMark ? "Mark" : "Undo");
>     GCTraceConcTime(Info, gc) tt(title);
> 
> Leading underscores are reserved for members of structs and classes in Hotspot. I suggested `title` here, but `format` would be as good.
> 
> Apart from that lgtm. Thanks for investigating this.

Was just about to make the same comment :)

-------------

PR: https://git.openjdk.java.net/jdk/pull/3589