RFR: 8265450: Merge PreservedMarksSet::restore code paths

Thomas Schatzl tschatzl at openjdk.java.net
Wed Apr 21 15:52:34 UTC 2021


On Tue, 20 Apr 2021 10:36:21 GMT, Stefan Johansson <sjohanss at openjdk.org> wrote:

>> Hi all,
>> 
>>   can I have reviews for this refactoring  that merges parallel and serial preserved marks restoration during evacuation failure into a single code path, simply by having the serial path call the parallel path in the VM thread.
>> 
>> This just reduces code and avoids the potential bugs when updating one path but not the other (which already happened).
>> 
>> The execution difference should not really matter for Serial GC where the serial path is executed:
>> - we are talking about the evacuation failure path
>> - there are likely a lot of preserved marks (random writes to the heap) that offset these two additional calls and some tiny superfluous member initialization.
>> 
>> Testing: tier1
>> 
>> Thanks,
>>   Thomas
>
> Looks good. Just a small comment.

Thanks @kstefanj @walulyai for your reviews.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3584



More information about the hotspot-gc-dev mailing list