RFR: 8265461: G1: Forwarding pointer removal thread sizing [v2]

Leo Korinth lkorinth at openjdk.java.net
Thu Apr 22 10:10:22 UTC 2021


On Wed, 21 Apr 2021 15:43:14 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> src/hotspot/share/gc/g1/g1EvacFailure.cpp line 211:
>> 
>>> 209: 
>>> 210: public:
>>> 211:   RemoveSelfForwardPtrHRClosure(G1RedirtyCardsQueueSet* rdcqs, uint worker_id, uint volatile* num_failed_regions) :
>> 
>> Maybe increment failed regions through G1CollectedHeap instead of a pointer to the value?
>
> You probably mean `G1ParRemoveSelfForwardPtrsTask`. I would not want to add that counter to `G1CollectedHeap` if possible. The suggestion seems to make the code just more verbose, not "cleaner", but that is subjective of course.

Okay.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3585



More information about the hotspot-gc-dev mailing list