RFR: 8256155: Allow multiple large page sizes to be used on Linux [v29]

Stefan Johansson sjohanss at openjdk.java.net
Mon Apr 26 08:53:46 UTC 2021


On Mon, 26 Apr 2021 08:34:26 GMT, Stefan Johansson <sjohanss at openjdk.org> wrote:

>> src/hotspot/os/linux/os_linux.cpp line 3767:
>> 
>>> 3765:   } else {
>>> 3766:     _large_page_size = default_large_page_size;
>>> 3767:   }
>> 
>> Move this part up to be done before you populate `_page_sizes` with the page sizes from `all_page_sizes`. Then you can use `_large_page_size` as the maximum page size that you add to `_page_sizes` and you don't have to care about `LargePageSizeInBytes` in that for-loop.
>
> I also think that the log-tag should be `pagesize`.

The comment here could also be updated: 

// Check LargePageSizeInBytes and setup _large_page_size to hold 
// the maximum allowed large page size. If not set the default large 
// page size is used as the maximum. ```

-------------

PR: https://git.openjdk.java.net/jdk/pull/1153



More information about the hotspot-gc-dev mailing list