RFR: 8234446: Post-CMS workgroup hierarchy cleanup

[Thomas Schatzl]

On Fri, 23 Apr 2021 20:06:03 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

> Collapse workgroup hierarchy and some general cleanup.
> 
> Tested; hotspot_gc

Mostly further cleanup suggestions.

src/hotspot/share/gc/shared/workerManager.hpp line 53:

> 51:   // If initializing = false, there are already some number of worker
> 52:   // threads and a failure would not be optimal but should not be fatal.
> 53:   static uint add_workers (WorkGang* holder,

s/holder/workers

src/hotspot/share/gc/shared/workerManager.hpp line 61:

> 59: 
> 60:   // Log (at trace level) a change in the number of created workers.
> 61:   static void log_worker_creation(WorkGang* holder,

s/holder/workers

src/hotspot/share/gc/shared/workgroup.cpp line 133:

> 131: 
> 132: WorkGang::WorkGang(const char* name, uint workers, bool are_GC_task_threads, bool are_ConcurrentGC_threads) :
> 133:       _workers(NULL),

Pre-existing: the indentation is completely arbitrary here. Please use something like 2 spaces.

src/hotspot/share/gc/shared/workgroup.hpp line 84:

> 82: // The work gang is the collection of workers to execute tasks.
> 83: // The number of workers run for a task is "_active_workers"
> 84: // while "_total_workers" is the number of available of workers.

Pre-existing: The second "of" is one too many.

src/hotspot/share/gc/shared/workgroup.hpp line 86:

> 84: // while "_total_workers" is the number of available of workers.
> 85: class WorkGang : public CHeapObj<mtInternal> {
> 86:  private:

The `private` can be removed.

-------------

Changes requested by tschatzl (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/3663