RFR: 8260267: ZGC: Reduce mark stack usage [v3]
Per Liden
pliden at openjdk.java.net
Fri Apr 30 12:30:20 UTC 2021
On Thu, 29 Apr 2021 19:27:28 GMT, Stefan Johansson <sjohanss at openjdk.org> wrote:
>> Per Liden has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Review comments from StefanJ and Albert
>
> src/hotspot/share/gc/z/zMarkStackAllocator.cpp line 72:
>
>> 70:
>> 71: static bool is_high_usage(size_t size) {
>> 72: // Consider usage to be high if we've used more than a 8th of the available space.
>
> "a 8th" -> "an 8th" or "one 8th"
Fixed!
> src/hotspot/share/gc/z/zMarkStackAllocator.cpp line 101:
>
>> 99:
>> 100: log_debug(gc, marking)("Expanding mark stack space: " SIZE_FORMAT "M->" SIZE_FORMAT "M (%s Usage)",
>> 101: old_size / M, new_size / M, _high_usage ? "High" : "Low");
>
> A bit strange to only have "Low" and "High" usage, maybe "Normal" and "High" would be more accurate.
Fixed!
-------------
PR: https://git.openjdk.java.net/jdk/pull/3460
More information about the hotspot-gc-dev
mailing list