RFR: 8266056: runtime/stringtable/StringTableCleaningTest.java failed with "RuntimeException: Missing Callback in [10, 11]" [v2]

[Per Liden]

On Fri, 30 Apr 2021 12:36:13 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Per Liden has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review comments from David
>
> test/hotspot/jtreg/runtime/stringtable/StringTableCleaningTest.java line 63:
> 
>> 61:         OutputAnalyzer output = ProcessTools.executeTestJvm(subargs);
>> 62:         output.outputTo(System.out);
>> 63:         output.errorTo(System.out);
> 
> The normal way to do this is to call output.reportDiagnosticSummary(). But you only do that after the actual checks, when you know you have success, as in the error cases it will be called anyway and you don't want the output twice.

Hmm, I see now that adding lines those is unnecessary, so I'll just remove them. Both shouldHaveExitValue() and checkOutput() seem to do the right thing. Not sure why I thought they didn't.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3815