RFR: 8271722: [TESTBUG] gc/g1/TestMixedGCLiveThreshold.java can fail if G1 Full GC uses >1 workers [v3]

[Richard Reingruber]

On Wed, 4 Aug 2021 07:51:07 GMT, Richard Reingruber <rrich at openjdk.org> wrote:

>> I tried to make this pr is dependent on #4968. Hope this works...
>> 
>> The change fixes a test issue in gc/g1/TestMixedGCLiveThreshold.java by adding
>> the option `-XX:ParallelGCThreads=1`. This prevents the full gc from running
>> with more than one worker because if it would do that, live data could be
>> distributed into several regions and one of them could be selected for
>> collection which is unexpected with `-XX:G1MixedGCLiveThresholdPercent=25`.
>> 
>> Please refer to the JBS-Item for more details.
>> 
>> Thanks, Richard.
>
> Richard Reingruber has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - Merge branch 'master'
>  - 8271722: [TESTBUG] gc/g1/TestMixedGCLiveThreshold.java can fail if G1 Full GC uses >1 workers
>  - start

> 
> 
> The dependent pull request has now been integrated, and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:
> 
> ```shell
> git checkout JDK-8271721-split-TestMixedGCLiveThreshold
> git fetch https://git.openjdk.java.net/jdk master
> git merge FETCH_HEAD
> # if there are conflicts, follow the instructions given by git merge
> git commit -m "Merge master"
> git push
> ```

Hi @edvbld,

this is my first dependent pr. So far it went well but now I've got issues with the procedure above.

First: ist there a `-b` missing in `git checkout JDK-8271721-split-TestMixedGCLiveThreshold`?

I've executed all the steps above (with -b in the first command) but I still see a commit from #4968 in this pr's commits.

Besides that I don't quite understand how it would help to create that new branch and push it to my personal fork.

I expected merging master into this pr's branch (https://github.com/reinrich/jdk/tree/8271722__TESTBUG__gc_g1_TestMixedGCLiveThreshold_java_can_fail_if_G1_Full_GC_uses__gt_1_workers) would help but that didn't.

Can you help to get rid of the 'start' commit by @tstuefe in this pr's commits?

Cheers, Richard.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4971