RFR: 8271884: G1CH::_expand_heap_after_alloc_failure is no longer needed

Kim Barrett kbarrett at openjdk.java.net
Mon Aug 9 04:38:31 UTC 2021


On Fri, 6 Aug 2021 10:43:19 GMT, Ivan Walulya <iwalulya at openjdk.org> wrote:

> Hi,
> 
> Please review this change to remove _expand_heap_after_alloc_failure. Checks for old_is_full(), survivor_is_full(), and G1CollectedHeap::has_more_regions() should eliminate repeated expansion attempts.
> 
> Testing; tier 1

Change looks good.

Testing should include verifying there isn't large amounts of output when
the appropriate logging is enabled and there are expansion failures. I filed
the RFE based on code-examination; it would be a pain if I missed something
and this flag actually is still needed.

-------------

Marked as reviewed by kbarrett (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/5030



More information about the hotspot-gc-dev mailing list