RFR: 8272093: Extract evacuation failure injection from G1CollectedHeap
Albert Mingkun Yang
ayang at openjdk.java.net
Mon Aug 9 11:51:34 UTC 2021
On Mon, 9 Aug 2021 09:25:30 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:
> Hi all,
>
> can I have reviews for this change that extracts out the evacuation failure injection mechanism from `G1CollectedHeap` into its own class?
> This reduces the amount of code in `G1CollectedHeap` a bit, moving somewhat uninteresting but somewhat important (testing) code out from there. Also documented it a bit. The other reason was that imho it stuck out a bit due to the ifdef's in `G1CollectedHeap`.
>
> I checked that gcc does compile out the call to `evacuation_should_fail()` in `G1ParScanThreadState` in product mode.
>
> Testing: tier1, local testing
>
> Thanks,
> Thomas
Marked as reviewed by ayang (Committer).
-------------
PR: https://git.openjdk.java.net/jdk/pull/5047
More information about the hotspot-gc-dev
mailing list