RFR: 8271946: Cleanup leftovers in Space and subclasses [v2]

Stefan Karlsson stefank at openjdk.java.net
Tue Aug 10 07:27:29 UTC 2021


On Sat, 7 Aug 2021 11:08:55 GMT, Roman Kennke <rkennke at openjdk.org> wrote:

>> There are a number of methods in (Compactible)Space that seem trivially implemented. E.g. obj_size(), adjust_obj_size(), scanned_block_is_obj() etc. I believe they are leftovers from CMS (not sure) but looks like they can be replaced by obj->size() or removed altogether. Also, the the related templated methods scan_and_forward(), scan_and_adjust_pointers() and scan_and_compact() can be directly and mechanically inlined into their callers. It makes the code more readable.
>> 
>> Testing:
>>  - [x] hotspot_gc
>>  - [x] tier1
>>  - [ ] tier2
>
> Roman Kennke has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove obsolete comments

Marked as reviewed by stefank (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/5031



More information about the hotspot-gc-dev mailing list