RFR: 8272216: G1: replace G1ParScanThreadState::_dest with a constant [v2]
Kim Barrett
kbarrett at openjdk.java.net
Tue Aug 10 10:48:54 UTC 2021
On Tue, 10 Aug 2021 10:46:20 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:
>> Simple change of removing an array with statically-known identical elements.
>>
>> Test: hotspot_gc
>
> Albert Mingkun Yang has updated the pull request incrementally with one additional commit since the last revision:
>
> review
Looks good. Just a suggested change to assert placement.
src/hotspot/share/gc/g1/g1ParScanThreadState.cpp line 361:
> 359: }
> 360: }
> 361: assert(region_attr.is_young() || region_attr.is_old(), "must be either Young or Old");
I think I'd rather have this assert at the beginning of the function.
-------------
Marked as reviewed by kbarrett (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/5065
More information about the hotspot-gc-dev
mailing list