RFR: 8272439: G1: add documentation to G1CardSetInlinePtr [v2]

Fri Aug 13 11:11:49 UTC 2021

On Fri, 13 Aug 2021 10:06:01 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> Albert Mingkun Yang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review
>
> src/hotspot/share/gc/g1/g1CardSet.hpp line 50:
> 
>> 48: 
>> 49: class G1CardSetConfiguration {
>> 50:   // #bits required to hold the max card index; log(#cards_per_region)
> 
> I would prefer a real sentence like `// [Holds] the number of bits required to cover the maximum card index for the regions covered by this card set.`.

Fixed.

> src/hotspot/share/gc/g1/g1CardSetContainers.hpp line 70:
> 
>> 68: // |unused|   ...   |  card_index1  | card_index0  |SSS00|
>> 69: // +------+         +---------------+--------------+-----+
>> 70: 
> 
> Unnecessary extra newline

Removed.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5108