RFR: 8267185: Add string deduplication support to ParallelGC

[Kim Barrett]

On Wed, 11 Aug 2021 15:11:57 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> Hi all,
>> 
>> Please review this change to add string deduplication support to ParallelGC.
>> 
>> Testing: All string deduplication tests, and Tier 1-5.
>
> src/hotspot/share/gc/parallel/parallelScavengeHeap.hpp line 143:
> 
>> 141: 
>> 142:   void safepoint_synchronize_begin();
>> 143:   void safepoint_synchronize_end();
> 
> I see no callers of these new functions.

Oh, never mind.  These are overriding virtual function declarations.  Please add `virtual`.  The modern style would be to use `override`, but gcc warns if some but not all of a class's overridden virtual functions use `override`, and you probably don't want to do that update for this class as part of this change.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5085