RFR: 8267833: Improve G1CardSetInlinePtr::add() [v2]

Ivan Walulya iwalulya at openjdk.java.net
Mon Aug 16 10:03:53 UTC 2021


On Mon, 16 Aug 2021 08:09:25 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> Ivan Walulya has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Kim review
>
> src/hotspot/share/gc/g1/g1CardSetContainers.inline.hpp line 54:
> 
>> 52:     uint num_elems = num_cards_in(_value);
>> 53:     if (num_elems > 0) {
>> 54:       cur_idx = find(card_idx, bits_per_card, cur_idx, num_elems);
> 
> I found the naming here a bit confusing, with `num_elems` here but `end_at` in the find function.  Similarly in `contains`.

Fixed, opted to use `num_elems` in find function too.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5067



More information about the hotspot-gc-dev mailing list