RFR: 8267185: Add string deduplication support to ParallelGC [v2]

Kim Barrett kbarrett at openjdk.java.net
Mon Aug 16 11:16:30 UTC 2021


On Mon, 16 Aug 2021 09:48:05 GMT, Ivan Walulya <iwalulya at openjdk.org> wrote:

>> Hi all,
>> 
>> Please review this change to add string deduplication support to ParallelGC.
>> 
>> Testing: All string deduplication tests, and Tier 1-5.
>
> Ivan Walulya has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Kim review

Looks good.

src/hotspot/share/gc/parallel/psPromotionManager.inline.hpp line 290:

> 288: 
> 289:       if (psStringDedup::is_candidate_from_evacuation(new_obj, new_obj_is_tenured)) {
> 290:           _string_dedup_requests.add(o);

Update indentation?  Or is github not showing the whitespace-only change?

-------------

Marked as reviewed by kbarrett (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/5085



More information about the hotspot-gc-dev mailing list