RFR: 8272629: G1: simplify G1GCParPhaseTimesTracker constructor API

Stefan Johansson sjohanss at openjdk.java.net
Wed Aug 18 11:45:27 UTC 2021


On Wed, 18 Aug 2021 10:31:29 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

> Simple change of removing an always-true argument in `G1GCParPhaseTimesTracker`.
> 
> Test: hotspot_gc

>From what I can tell this argument is still needed since we can do multiple calls to `merge_heap_roots(false)` in `G1CollectedHeap::evacuate_optional_collection_set()`. So for the `G1GCPhaseTimes::OptMergeRS` phase we need to sometimes use `record_or_add_time_secs()` to avoid the assert/overwriting data. Or am I missing something?

-------------

PR: https://git.openjdk.java.net/jdk/pull/5162



More information about the hotspot-gc-dev mailing list