RFR: 8272579: G1: remove unnecesary null check in G1ParScanThreadStateSet::flush [v2]

Albert Mingkun Yang ayang at openjdk.java.net
Wed Aug 18 15:56:48 UTC 2021


On Wed, 18 Aug 2021 13:15:53 GMT, Stefan Johansson <sjohanss at openjdk.org> wrote:

>> In `G1CollectedHeap::evacuate_initial_collection_set`:
>> 
>> 
>> G1ParScanThreadStateSet per_thread_states(this,
>>                                           &rdcqs,
>>                                           workers()->active_workers(), <---- setting up states for workers
>>                                           collection_set()->young_region_length(),
>>                                           collection_set()->optional_region_length());
>> ...
>> evacuate_initial_collection_set(&per_thread_states, may_do_optional_evacuation);
>> \
>>  -- task_time = run_task_timed(&g1_par_task); <--- launching all workers
>> 
>> Therefore, I think the assertion is safe.
>> 
>>> does it hold below in record_unused_optional_region() as well?
>> 
>> I think so.
>
> In that case I would change that one as well, but it please run some more testing to ensure it is safe.

Changed; and tier1-3 pass.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5145



More information about the hotspot-gc-dev mailing list