RFR: 8267185: Add string deduplication support to ParallelGC [v4]

Kim Barrett kbarrett at openjdk.java.net
Fri Aug 20 06:08:27 UTC 2021


On Thu, 19 Aug 2021 14:31:03 GMT, Ivan Walulya <iwalulya at openjdk.org> wrote:

>> Hi all,
>> 
>> Please review this change to add string deduplication support to ParallelGC.
>> 
>> Testing: All string deduplication tests, and Tier 1-5.
>
> Ivan Walulya has updated the pull request incrementally with one additional commit since the last revision:
> 
>   albertnetymk review

Changes requested by kbarrett (Reviewer).

src/hotspot/share/gc/parallel/psStringDedup.hpp line 39:

> 37:   // If to is young then age should be the new (survivor's) age.
> 38:   // if to is old then age should be the age of the copied from object.
> 39:   static bool is_candidate_from_evacuation(oop obj,

This comment was just copied from G1 and isn't right for this implementation.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5085



More information about the hotspot-gc-dev mailing list