RFR: 8272609: Add string deduplication support to SerialGC [v10]

Denghui Dong ddong at openjdk.java.net
Sat Aug 21 14:39:27 UTC 2021


On Fri, 20 Aug 2021 21:24:01 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> Denghui Dong has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix build error
>
> src/hotspot/share/gc/serial/genMarkSweep.cpp line 115:
> 
>> 113:   deallocate_stacks();
>> 114: 
>> 115:   MarkSweep::_string_dedup_requests->flush();
> 
> Similarly, `flush` should be called inside `mark_sweep_phase1`, right after ref-processing.

Thanks for your review and Kim's detailed explanation.

I think putting this invocation here or the position you suggest should have no effect on the result, so I tend not to make this modification.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5153



More information about the hotspot-gc-dev mailing list