RFR: 8272611: Use parallel heap inspection when print classhisto info in gc log
Thomas Schatzl
tschatzl at openjdk.java.net
Mon Aug 30 08:25:31 UTC 2021
On Fri, 27 Aug 2021 09:08:34 GMT, Bin Liao <github.com+3094961+buddyliao at openjdk.org> wrote:
>> src/hotspot/share/gc/shared/collectedHeap.cpp line 552:
>>
>>> 550: LogStream ls(lt);
>>> 551: uint parallel_thread_num = MAX2<uint>(1, (uint)os::initial_active_processor_count() * 3 / 8);
>>> 552: VM_GC_HeapInspection inspector(&ls, false /* ! full gc */, parallel_thread_num);
>>
>> Pre-existing: the comment next to a bool constant in a parameter list should show the name of the parameter, i.e. s/! full_gc/request_full_gc/. Maybe change this as appropriate in other callers too.
>
>> Pre-existing: the comment next to a bool constant in a parameter list should show the name of the parameter, i.e. s/! full_gc/request_full_gc/. Maybe change this as appropriate in other callers too.
>
> Sounds reasonable, so I will change here in this PR, and the other places in another new pr, is it ok?
Your call.
-------------
PR: https://git.openjdk.java.net/jdk/pull/5158
More information about the hotspot-gc-dev
mailing list