RFR: 8272651: G1 heap region info print order changed by JDK-8269914 [v2]

[Stefan Johansson]

On Mon, 30 Aug 2021 08:54:09 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> Stefan Johansson has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   HeapMark needs to be below JFRMark to make sure all GC events are withing start and end event.
>
> src/hotspot/share/gc/g1/g1FullCollector.hpp line 61:
> 
>> 59: 
>> 60: // Full GC Mark that holds GC id and CPU time trace. Needs to be separate
>> 61: // from the G1FullCollector and G1FullGCScope to get consistent logging.
> 
> I think saying just "consistent logging" here is too terse; some elaboration (background info and/or with/without this separation comparison) could make the reasoning more explicit.

Suggestion:

// from the G1FullCollector and G1FullGCScope to allow the Full GC logging
// to have the same structure as the Young GC logging.


Would this be enough? I don't want to add to many details as it might easily get stale. But I wanted the comment to let the reader know why this isn't folded in to the other structures.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5252