RFR: 8276299: G1: Unify the wording buffer/node/element in G1SegmentedArrayXxx, G1CardSetXxx and related classes

Hamlin Li mli at openjdk.java.net
Wed Dec 1 11:38:28 UTC 2021


On Wed, 1 Dec 2021 09:53:48 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> Currently, the words "buffer", "node" and "element" are used together in G1SegmentedArrayXxx, G1CardSetXxx and related classes in an inconsistent way, which is very unfavorable for understanding.
>> 
>> We should not confuse buffer and node together, and not confuse node and element together. The new wording should be based on something like the following rule:
>> 
>> segmented array (1) -- segment (N) -- slot (M)
>
> src/hotspot/share/gc/g1/g1SegmentedArray.inline.hpp line 222:
> 
>> 220: 
>> 221:   while (true) {
>> 222:     Slot* slot = (Slot*) cur->get_new_slot();
> 
> Suggestion:
> 
>     Slot* slot = (Slot*)cur->get_new_slot();

Thanks! very detailed review!

-------------

PR: https://git.openjdk.java.net/jdk/pull/6605



More information about the hotspot-gc-dev mailing list